Skip to content

[IRC] Add checks/warnings at init stage#178

Merged
epernod merged 6 commits into
sofa-framework:masterfrom
fredroy:update_mech_checks
Apr 25, 2025
Merged

[IRC] Add checks/warnings at init stage#178
epernod merged 6 commits into
sofa-framework:masterfrom
fredroy:update_mech_checks

Conversation

@fredroy
Copy link
Copy Markdown
Contributor

@fredroy fredroy commented Apr 22, 2025

Continuation of

If the required MechanicalObject and topology is not well set (number of nodes, edges), the warning comes during the simulation runtime (which will be too late).
So in this PR we check at the init stage and inform the user already.
Hesitating to

  • convert to error + setting componentState to invalid
  • or fill the mechanical object and topology to make it safe 🤔

@fredroy fredroy added pr: clean pr: status to review To notify reviewers to review this pull-request labels Apr 22, 2025
@fredroy fredroy force-pushed the update_mech_checks branch from 4f428ea to ef8b05e Compare April 22, 2025 23:27
@fredroy
Copy link
Copy Markdown
Contributor Author

fredroy commented Apr 22, 2025

[ci-build][with-all-tests]

@bakpaul bakpaul added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Apr 24, 2025
@fredroy fredroy force-pushed the update_mech_checks branch from ef8b05e to 5ab0aff Compare April 24, 2025 07:07
@fredroy fredroy force-pushed the update_mech_checks branch from 5ab0aff to aa9b355 Compare April 25, 2025 00:01
@epernod epernod merged commit a3ad75d into sofa-framework:master Apr 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants